refactor: replace dirctl binary with native code#65
Closed
arpad-csepi wants to merge 2 commits into
Closed
Conversation
arpad-csepi
force-pushed
the
refactor/native-local-sign-verify
branch
from
cc33fa3 to
1f972fd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
| from nacl.secret import SecretBox | ||
|
|
||
| _ENCRYPTED_KEY_TYPES = ( |
Signed-off-by: Árpád Csepi <csepi.arpad@outlook.com>
arpad-csepi
force-pushed
the
refactor/native-local-sign-verify
branch
from
1f972fd to
3d94ae0
Compare
| for other_name in san_ext.get_values_for_type(OtherName): | ||
| if other_name.type_id.dotted_string == _OTHERNAME_OID: | ||
| identities.add(other_name.value.decode()) | ||
| except Exception: |
arpad-csepi
force-pushed
the
refactor/native-local-sign-verify
branch
from
f3ceaf8 to
4ec974f
Compare
Signed-off-by: Árpád Csepi <csepi.arpad@outlook.com>
arpad-csepi
force-pushed
the
refactor/native-local-sign-verify
branch
from
4ec974f to
68939da
Compare
| try: | ||
| issuer_ext = cert.extensions.get_extension_for_oid(_FULCIO_ISSUER_OID).value | ||
| issuer = _decode_fulcio_extension_string(issuer_ext.value) # type: ignore[attr-defined] | ||
| except ExtensionNotFound: |
Member
Author
|
The solution needs more work and a different approach might be better in the end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.